Skip to content

Conversation

rickeylev
Copy link
Collaborator

My original change to use the bazel-contrib BCR publishing workflow was horribly broken.
This fixes a variety of issues.

  • Fix the workflow call secrets variable name
  • Allow getting the BCR publishing token from the workflow arg (the release
    workflow calls it)
  • Fix the overall syntax of the workflows. It was just entirely invalid in
    several regards.
  • Fix the yaml -> yml file name reference. NGL, it took me longer than I'd
    like to admit to see that, eh.

Along the way, some cleanups and improvements

  • Allow specifying a particular tag to release, while using workflow state from
    a different commit. This allows us to make fixes on main, and then use it to
    manually re-trigger a tag to be released.
  • Add descriptions for workflow inputs
  • Allow bcr token to be passed to release. This will allow e.g. automatically
    scheduled releases.
  • Quote shell variables because its good practice.

@rickeylev rickeylev requested a review from aignas as a code owner October 17, 2025 04:28
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@rickeylev rickeylev mentioned this pull request Oct 17, 2025
10 tasks
secrets:
publish_token: ${{ secrets.BCR_PUBLISH_TOKEN }}
# Necessary to push to the BCR fork, and to open a pull request against a registry
publish_token: ${{ secrets.publish_token || secrets.BCR_PUBLISH_TOKEN }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: why not have them to be the same thing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants